Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for optional channel ID in send/recv error message #19325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

Account for optional channel ID in send/recv error message #19325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions xla/service/hlo_verifier.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2286,15 +2286,14 @@ absl::Status CheckSameChannel(const HloInstruction* instr1,
return Internal(
"Expected to have the same channel id, actual channel ids are: %s "
"(%d), %s (%d)",
instr1->ToString(), *instr1->channel_id(), instr2->ToString(),
*instr2->channel_id());
instr1->ToString(), instr1->channel_id().value_or(-1),
instr2->ToString(), instr2->channel_id().value_or(-1));
}
return absl::OkStatus();
}

// Checks if the given two instructions have the same is_host_transfer
// attribute value. Instructions must be send/recv instructions or their
// 'done' variant.
// Checks if the given two instructions have the same is_host_transfer attribute
// value. Instructions must be send/recv instructions or their 'done' variant.
absl::Status CheckSameIsHostTransfer(const HloInstruction* instr1,
const HloInstruction* instr2) {
const HloSendRecvInstruction* send_recv1 =
Expand Down
Loading