Skip to content

Commit

Permalink
incorporate '--json-output' flag to the 'zrok reserve' command (#422)
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelquigley committed Oct 25, 2023
1 parent aba9f68 commit 870c1a0
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 18 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# v0.4.11

FEATURE: The `zrok reserve` command now incorporates the `--json-output|-j` flag, which outputs the reservation details as JSON, rather than as human-consumable log messages. Other commands will produce similar output in the future (https://github.com/openziti/zrok/issues/422)

FIX: Include `--oauth-provider` and associated flags for the `zrok reserve` command, allowing reserved shares to specify OAuth authentication (https://github.com/openziti/zrok/issues/421)

# v0.4.10
Expand Down
33 changes: 17 additions & 16 deletions cmd/zrok/reserve.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package main

import (
"encoding/json"
"fmt"
"github.com/openziti/zrok/environment"
"github.com/openziti/zrok/sdk"
Expand All @@ -18,6 +19,7 @@ type reserveCommand struct {
basicAuth []string
frontendSelection []string
backendMode string
jsonOutput bool
oauthProvider string
oauthEmailDomains []string
oauthCheckInterval time.Duration
Expand All @@ -33,7 +35,7 @@ func newReserveCommand() *reserveCommand {
command := &reserveCommand{cmd: cmd}
cmd.Flags().StringArrayVar(&command.frontendSelection, "frontends", []string{"public"}, "Selected frontends to use for the share")
cmd.Flags().StringVarP(&command.backendMode, "backend-mode", "b", "proxy", "The backend mode {proxy, web, <tcpTunnel, udpTunnel>, caddy}")

cmd.Flags().BoolVarP(&command.jsonOutput, "json-output", "j", false, "Emit JSON describing the created reserved share")
cmd.Flags().StringArrayVar(&command.basicAuth, "basic-auth", []string{}, "Basic authentication users (<username:password>,...)")
cmd.Flags().StringVar(&command.oauthProvider, "oauth-provider", "", "Enable OAuth provider [google, github]")
cmd.Flags().StringArrayVar(&command.oauthEmailDomains, "oauth-email-domains", []string{}, "Allow only these email domains to authenticate via OAuth")
Expand All @@ -55,10 +57,7 @@ func (cmd *reserveCommand) run(_ *cobra.Command, args []string) {
case "proxy":
v, err := parseUrl(args[1])
if err != nil {
if !panicInstead {
tui.Error("invalid target endpoint URL", err)
}
panic(err)
tui.Error("invalid target endpoint URL", err)
}
target = v

Expand All @@ -80,10 +79,7 @@ func (cmd *reserveCommand) run(_ *cobra.Command, args []string) {

env, err := environment.LoadRoot()
if err != nil {
if !panicInstead {
tui.Error("error loading environment", err)
}
panic(err)
tui.Error("error loading environment", err)
}

if !env.IsEnabled() {
Expand All @@ -109,14 +105,19 @@ func (cmd *reserveCommand) run(_ *cobra.Command, args []string) {
}
shr, err := sdk.CreateShare(env, req)
if err != nil {
if !panicInstead {
tui.Error("unable to create share", err)
}
panic(err)
tui.Error("unable to create share", err)
}

logrus.Infof("your reserved share token is '%v'", shr.Token)
for _, fpe := range shr.FrontendEndpoints {
logrus.Infof("reserved frontend endpoint: %v", fpe)
if !cmd.jsonOutput {
logrus.Infof("your reserved share token is '%v'", shr.Token)
for _, fpe := range shr.FrontendEndpoints {
logrus.Infof("reserved frontend endpoint: %v", fpe)
}
} else {
out, err := json.Marshal(shr)
if err != nil {
tui.Error("error emitting JSON", err)
}
fmt.Println(string(out))
}
}
4 changes: 2 additions & 2 deletions sdk/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ type ShareRequest struct {
}

type Share struct {
Token string
FrontendEndpoints []string
Token string `json:"token"`
FrontendEndpoints []string `json:"frontend_endpoints"`
}

type AccessRequest struct {
Expand Down

0 comments on commit 870c1a0

Please sign in to comment.