refactor(storage): update to support buf lint and generation automation #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek-koltun
force-pushed
the
storage-automate
branch
2 times, most recently
from
b4e4d75
to
4728070
Compare
artek-koltun
force-pushed
the
storage-automate
branch
2 times, most recently
from
7bbbd85
to
4728070
Compare
sandersms
approved these changes
Dec 15, 2023
artek-koltun
force-pushed
the
storage-automate
branch
from
4728070
to
e62ecbb
Compare
artek-koltun
force-pushed
the
storage-automate
branch
from
fb7741c
to
8857b25
Compare
This was
linked to
issues
Jan 5, 2024
uuid type is just a string value in dedicated message. No need in that type if we can use string type directly. Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
we are not using those bindings at the moment. Can be added back when required. Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
to satisfy linters. scsi parent annotations are not correct and should be fixed later. Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
required to support buf operations Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
artek-koltun
force-pushed
the
storage-automate
branch
from
8857b25
to
3f2c70e
Compare
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition storage to the buf lint and buf generate operation to allow for automation of the protobuf file generation.
Support for cpp and java are being removed at this time. Generation supports go and python. Support for other languages can be added as needed by the buf.gen.yaml file.
Be aware that the .proto files are moved up from the v1alpha1 directory to support the buf operation and to keep the version of the generated files in a separate (v1, v1alpha1, etc.) directory structure. This will allow for the future ability to autogenerate the files and place them in a separate repo location.
uuid message is replaced to string type, based on the internal discussion and an intention to remove common package at all.
grpc-gateway is generated as a part of the build, so fixes #332