Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add apilinter #454

Merged
merged 2 commits into from
Jun 26, 2024
Merged

ci: add apilinter #454

merged 2 commits into from
Jun 26, 2024

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Jun 26, 2024

Close #444

While there is no google api linter integration with buf, we can run it in our make file separately.

#455

@artek-koltun artek-koltun force-pushed the ci-add-apilinter branch 3 times, most recently from f74ab7d to db6b7dd Compare June 26, 2024 07:55
use underscores for strong style

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun marked this pull request as ready for review June 26, 2024 08:11
@artek-koltun artek-koltun requested a review from a team as a code owner June 26, 2024 08:11
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition for api linting that is missing from buf currently.

@sandersms sandersms merged commit 4adb739 into opiproject:main Jun 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include https://github.com/googleapis/api-linter in protobuf checking.
2 participants