Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bgp): extent with a few new fields/messages #460

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

KeithWiles
Copy link
Contributor

Extend BGPPeerSpec to add a description field as a string reference. Extend BGPeerAfSpec to add a couple messages for prefix, map and advertisements. The added messages provide max_prefixes, route_map and NLRI advertisement support.

Signed-off-by: Keith Wiles keith.wiles@intel.com
Signed-off-by: Chunduri, Uma S uma.s.chunduri@intel.com
Signed-off-by: Birkner, Matthew matthew.birkner@intel.com

@KeithWiles KeithWiles requested a review from a team as a code owner July 19, 2024 19:16
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see commitlint issues

Error: ✖ subject may not be empty
Error: ✖ type may not be empty
Error: commitlint failed

Extend BGPPeerSpec to add a description field as a string reference.
Extend BGPeerAfSpec to add a couple messages for prefix, map and
advertisements. The added messages provide max_prefixes, route_map and
NLRI advertisment support.

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Signed-off-by: Chunduri, Uma S <uma.s.chunduri@intel.com>
Signed-off-by: Birkner, Matthew <matthew.birkner@intel.com>
@sandersms
Copy link
Contributor

@KeithWiles You will need to correct the commit syntax and use one of the conventional commit types defined in
https://www.conventionalcommits.org/en/v1.0.0/#summary
and
https://github.com/conventional-changelog/commitlint

@KeithWiles KeithWiles changed the title improvement(bgp):extent with a few new fields/messages feat(bgp): extent with a few new fields/messages Jul 22, 2024
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - approved

@sandersms sandersms merged commit 49f6e67 into opiproject:main Jul 22, 2024
9 checks passed
@KeithWiles KeithWiles deleted the bgp-updates branch July 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants