Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ospf): adding support for OSPF protocol #461

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

KeithWiles
Copy link
Contributor

A new feature to support for OSPFv2 protocol using CRUD type APIs. The current APIs support the basic set of APIs for OSPF. These currently do not support all possible OSPF configurations.

Signed-off-by: Keith Wiles keith.wiles@intel.com
Signed-off-by: Chunduri, Uma S uma.s.chunduri@intel.com
Signed-off-by: Birkner, Matthew matthew.birkner@intel.com

A new feature to support for OSPFv2 protocol using CRUD type APIs. The
current APIs support the basic set of APIs for OSPF. These currently do
not support all possible OSPF configurations.

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@KeithWiles KeithWiles requested a review from a team as a code owner July 19, 2024 19:17
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hej, thank you for the contribution. Since you are reworking the cloud, could I ask you to remove disabled api linter checks here so we are confident that the new code is AIP compliant

@KeithWiles
Copy link
Contributor Author

Hi @artek-koltun I did not update the Makefile, but I can remove the disable and make locally or did you want me to include that change in my PR?

@artek-koltun
Copy link
Contributor

Hi @artek-koltun I did not update the Makefile, but I can remove the disable and make locally or did you want me to include that change in my PR?

I would prefer to have the cloud Makefile updated as a part of this PR

Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, we decided to resolve the linter issues in a follow-up PR

@artek-koltun artek-koltun merged commit 3a7e0d2 into opiproject:main Jul 23, 2024
9 checks passed
@KeithWiles KeithWiles deleted the feature-add-ospf branch July 24, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants