fix(security): correct security api proto namespace conflict #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
artek-koltun
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A namespace conflict exists with the security "ipsec.proto" file that needed to be corrected. The new ipsec.proto with the CRUD model support had the same name; but, was located in the v1alpha1 folder. The previous .proto file was in the v1 folder.
The v1 folder is used by the existing strongswan_bridge as well as referenced in some of the other bridge examples.
In updating the strongswan_ bridge to the new CRUD model, the .proto file had a conflict that was reported. To correct this in the interim until each bridge can be corrected, the name of the new .proto file is opi_ipsec.proto to allow a unique name.