Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FSSDK-9432] fix: fix to support arbitrary client names to be included in logx and odp events." #466

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

muzahidul-opti
Copy link
Contributor

Summary

Fix to support arbitrary client names to be included in logx and odp events.
This fix depends on the change in the java-sdk core (optimizely/java-sdk#524)

Test plan

Add unit tests for new APIs.
Pass all existing tests.

Issues

  • FSSDK-9432

… included in logx and odp events. (#459)"

This reverts commit 52f5f6d.
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 21883e3 into master Sep 20, 2023
20 of 22 checks passed
@muzahidul-opti muzahidul-opti deleted the revert-459-jae/client-name branch September 20, 2023 15:34
jaeopt added a commit that referenced this pull request Jan 16, 2024
…es to be included in logx and odp events. (#459)" (#466)"

This reverts commit 21883e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants