Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSSDK-10523 fix: integration test fix #486

Merged
merged 19 commits into from
Aug 23, 2024
Merged

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Aug 9, 2024

Summary

  • Android integration test fixed

Issues

@muzahidul-opti muzahidul-opti changed the title Ci testing FSSDK-10523 chore: integration test fix Aug 19, 2024
@muzahidul-opti muzahidul-opti changed the title FSSDK-10523 chore: integration test fix FSSDK-10523 fix: integration test fix Aug 19, 2024
@muzahidul-opti muzahidul-opti marked this pull request as ready for review August 19, 2024 13:26
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner August 19, 2024 13:26
Comment on lines +93 to +97
- name: Enable KVM
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? Required? @muzahidul-opti

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step ensures that emulator runs using KVM, which is necessary to run faster. Otherwise, emulator performance
could be significantly slow which may cause time out issue.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 70d50b9 into master Aug 23, 2024
9 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/ci-fixing branch August 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants