Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10578] R8: Keep name of Gson class #490

Closed
wants to merge 2 commits into from

Conversation

jamiesanson
Copy link
Contributor

This ensures the Java SDK is able to look up Gson, and select the correct config parser on Android platforms.

Closes #489.

This ensures the Java SDK is able to look up Gson, and select the correct config parser on Android platforms.
Copy link
Contributor

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution. Could you please sign in the CLA

Copy link
Contributor

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti changed the title R8: Keep name of Gson class [FSSDK-10578] R8: Keep name of Gson class Sep 17, 2024
@muzahidul-opti
Copy link
Contributor

muzahidul-opti commented Sep 18, 2024

@jamiesanson I have created an internal ticket (FSSDK-10578) to get this into the master branch.

@muzahidul-opti
Copy link
Contributor

An internal PR has been merged with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] R8 configuration breaks Gson use at runtime
2 participants