Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update keyring version from 1.1.6 to 1.2.1 to fix 'SecKeychainCreate'… #1

Closed
wants to merge 2 commits into from
Closed

update keyring version from 1.1.6 to 1.2.1 to fix 'SecKeychainCreate'… #1

wants to merge 2 commits into from

Conversation

ishih-opti
Copy link

@ishih-opti ishih-opti commented Aug 29, 2022 •
edited
Loading

  1. update keyring version from 1.1.6 to 1.2.1 to fix 'SecKeychainCreate' is deprecated: first deprecated in macOS 12.0 error

See 99designs/keyring#107

Error received compiling on OS Monterey (v12.5.1)

# github.com/keybase/go-keychain
cgo-gcc-prolog:81:11: warning: 'SecKeychainCreate' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:301:10: note: 'SecKeychainCreate' has been explicitly marked deprecated here
cgo-gcc-prolog:139:11: warning: 'SecKeychainLock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:357:10: note: 'SecKeychainLock' has been explicitly marked deprecated here
cgo-gcc-prolog:159:11: warning: 'SecKeychainOpen' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:287:10: note: 'SecKeychainOpen' has been explicitly marked deprecated here
cgo-gcc-prolog:183:11: warning: 'SecKeychainUnlock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:347:10: note: 'SecKeychainUnlock' has been explicitly marked deprecated here
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here
  1. Makefile: Also adding dist/aws-okta-$(VERSION)-darwin-arm64 support

@ishih-opti
update keyring version from 1.1.6 to 1.2.1 to fix 'SecKeychainCreate'…
ef3da64 
… is deprecated: first deprecated in macOS 12.0 error
@ishih-opti ishih-opti requested a review from a team August 30, 2022 17:22
mlabardini-opti
mlabardini-opti approved these changes Nov 2, 2022
View reviewed changes
Copy link

@mlabardini-opti mlabardini-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a large go mod update. Approved

@mlabardini-opti
Copy link

stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabardini-opti mlabardini-opti mlabardini-opti approved these changes

@lshofmann lshofmann Awaiting requested review from lshofmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishih-opti @mlabardini-opti