fixed comments

optimizely · Aug 2, 2023 · 745e361 · 745e361
1 parent 43c9308
commit 745e361
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/OptimizelySDK.Tests/ConfigTest/PollingProjectConfigManagerTest.cs b/OptimizelySDK.Tests/ConfigTest/PollingProjectConfigManagerTest.cs
@@ -142,21 +142,20 @@ public void TestTimedoutOnlyIfSchedulerStarted()
         [Test]
         public void TestWarnLogIfPollingTimeIsLessThanThirty()
         {
-            // period to call is 29 milliseconds
-            var configManager = new TestPollingProjectConfigManager(TimeSpan.FromMilliseconds(29),
-                TimeSpan.FromMilliseconds(20), true, LoggerMock.Object, new int[] { });
+            var below30Seconds = TimeSpan.FromSeconds(29);
+            _ = new TestPollingProjectConfigManager(below30Seconds,
+                TimeSpan.FromSeconds(10), true, LoggerMock.Object, new int[] { });
             LoggerMock.Verify(l => l.Log(LogLevel.WARN,
                 "Polling intervals below 30 seconds are not recommended."), Times.Once);
         }
-
         [Test]
         public void TestWarnLogNotTriggeredIfPollingTimeIsGreaterThanThirty()
         {
-            // period to call is 32 second
-            var configManager = new TestPollingProjectConfigManager(TimeSpan.FromSeconds(32),
-                TimeSpan.FromMilliseconds(31), true, LoggerMock.Object, new int[] { });
+            var above30Seconds = TimeSpan.FromMinutes(1);
+            _ = new TestPollingProjectConfigManager(above30Seconds,
+                TimeSpan.FromMilliseconds(10), true, LoggerMock.Object, new int[] { });
             LoggerMock.Verify(l => l.Log(LogLevel.WARN,
-                "Polling intervals below 30 seconds are not recommended."), Times.Once);
+                "Polling intervals below 30 seconds are not recommended."), Times.Never);
         }
 
         [Test]

diff --git a/OptimizelySDK/Config/PollingProjectConfigManager.cs b/OptimizelySDK/Config/PollingProjectConfigManager.cs
@@ -65,7 +65,7 @@ public PollingProjectConfigManager(TimeSpan period, TimeSpan blockingTimeout,
             Logger = logger;
             ErrorHandler = errorHandler;
             BlockingTimeout = blockingTimeout;
-            if (period.TotalMilliseconds < 30) 
+            if (period.Seconds < 30) 
             {
                 Logger?.Log(LogLevel.WARN, "Polling intervals below 30 seconds are not recommended.");
             }