Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9538] chore Cherry-pick & prep for 3.11.4 release #364

Merged
merged 21 commits into from
Jul 28, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Cherry-picked from main branch bug fix
  • Updated versions numbers including missed one
  • Add changelog update

Test plan

  • All unit tests and e2e non-AAT tests should pass
  • ODP e2e tests will be temporarily turned off

Issues

  • FSSDK-9538

* Fix non-RFC1123 formatting

* Update tests to ensure expected format

* Add more accurate assert

* Lint fixes

(cherry picked from commit 962bd68)
I can't believe I missed the main project fully 😫
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review July 28, 2023 17:32
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner July 28, 2023 17:32
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 9e08223 into release-3.11.4 Jul 28, 2023
9 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/pick-prep-3.11.4 branch July 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants