Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9783] Return Latest Experiment When Duplicate Keys in Config #370

Merged
merged 3 commits into from
Dec 4, 2023
Merged

[FSSDK-9783] Return Latest Experiment When Duplicate Keys in Config #370

merged 3 commits into from
Dec 4, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

When duplicate experiment key found in the data file, SDK returns correct experiment map in OptimizelyConfig

  • Keep the latest experiment key, found in the datafile experiment list
  • Add warning log "Duplicate keys found in datafile: {key-name}"

Test plan

  • Updated existing test for duplicate key
  • All other tests cases are expected to pass

Issues

@mikechu-optimizely
feat: log duplicate experiment keys
64630bd 
Also refactored private fields to readonly & standard names
@mikechu-optimizely
test: updated existing dupe exp keys test
e45067d 
Also refactored private fields to readonly & names
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review November 30, 2023 20:32
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner November 30, 2023 20:32
pulak-opti
pulak-opti approved these changes Dec 1, 2023
View reviewed changes
Copy link

@pulak-opti pulak-opti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for a clarification.
Otherwise, LGTM!

@mikechu-optimizely mikechu-optimizely merged commit c6213a9 into master Dec 4, 2023
11 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/handle-dupliate-experiment-key branch December 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulak-opti pulak-opti pulak-opti approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @pulak-opti