Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8581] chore: Prepare for 4.0.0 release #371

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Jan 16, 2024

Summary

  • Incremement version numbers removing the beta tag
  • Update changelog, readme.md, & license

Test plan

  • All unit and e2e test suites should pass

Issues

wwwhyy is this still something I have to do??? *coughs: AI*
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review January 16, 2024 15:45
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner January 16, 2024 15:45
Copy link

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a quick thought, shouldn't we need to update the readme file?

@mikechu-optimizely
Copy link
Contributor Author

LGTM. Just a quick thought, shouldn't we need to update the readme file?

That's a good question. What are you and @jaeopt adding/updating to the README.md?

@muzahidul-opti
Copy link

muzahidul-opti commented Jan 16, 2024

LGTM. Just a quick thought, shouldn't we need to update the readme file?

That's a good question. What are you and @jaeopt adding/updating to the README.md?

For mobile suit, sample api and version need to be updated.

@mikechu-optimizely
Copy link
Contributor Author

Ah yes. I see you have a version number in the Swift SDK README.md then searching I see that the C# SDK has a version number that's not been updated since 3.2 😬 .

I'll update that and the SDK Deployment runbook. Thanks.

This file needs to be reviewed & updates
This file needs to be reviewed & updates
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@jaeopt
Copy link
Contributor

jaeopt commented Jan 16, 2024

LGTM. Just a quick thought, shouldn't we need to update the readme file?

That's a good question. What are you and @jaeopt adding/updating to the README.md?

We can consider adding a line what his major release about. They can look at the release note, but one line of summary will be helpful.

bring pre-release beta notes up to the GA version section
@mikechu-optimizely
Copy link
Contributor Author

That's a good question. What are you and @jaeopt adding/updating to the README.md?

We can consider adding a line what his major release about. They can look at the release note, but one line of summary will be helpful.

What's the copy for the README one-liner addition? Will it age well with the 4.x.x?

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nit

CHANGELOG.md Outdated Show resolved Hide resolved
@mikechu-optimizely mikechu-optimizely merged commit 50533a9 into master Jan 16, 2024
11 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/prepare-release-4.0.0 branch January 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants