Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jaeopt committed May 7, 2024
1 parent 7879667 commit dc7e901
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 16 deletions.
25 changes: 13 additions & 12 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -94,21 +94,22 @@ configure(publishedProjects) {
}

dependencies {
compile group: 'commons-codec', name: 'commons-codec', version: commonCodecVersion
implementation group: 'commons-codec', name: 'commons-codec', version: commonCodecVersion

testCompile group: 'junit', name: 'junit', version: junitVersion
testCompile group: 'org.mockito', name: 'mockito-core', version: mockitoVersion
testCompile group: 'org.hamcrest', name: 'hamcrest-all', version: hamcrestVersion
testCompile group: 'com.google.guava', name: 'guava', version: guavaVersion
testImplementation group: 'junit', name: 'junit', version: junitVersion
testImplementation group: 'org.mockito', name: 'mockito-core', version: mockitoVersion
testImplementation group: 'org.hamcrest', name: 'hamcrest-all', version: hamcrestVersion
testImplementation group: 'com.google.guava', name: 'guava', version: guavaVersion

// logging dependencies (logback)
testCompile group: 'ch.qos.logback', name: 'logback-classic', version: logbackVersion
testCompile group: 'ch.qos.logback', name: 'logback-core', version: logbackVersion

testCompile group: 'com.google.code.gson', name: 'gson', version: gsonVersion
testCompile group: 'org.json', name: 'json', version: jsonVersion
testCompile group: 'com.googlecode.json-simple', name: 'json-simple', version: jsonSimpleVersion
testCompile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jacksonVersion
testImplementation group: 'ch.qos.logback', name: 'logback-classic', version: logbackVersion
testImplementation group: 'ch.qos.logback', name: 'logback-core', version: logbackVersion
testImplementation 'org.mock-server:mockserver-netty:5.1.1'

testImplementation group: 'com.google.code.gson', name: 'gson', version: gsonVersion
testImplementation group: 'org.json', name: 'json', version: jsonVersion
testImplementation group: 'com.googlecode.json-simple', name: 'json-simple', version: jsonSimpleVersion
testImplementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jacksonVersion
}

def docTitle = "Optimizely Java SDK"
Expand Down
2 changes: 0 additions & 2 deletions core-httpclient-impl/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ dependencies {
implementation project(':core-api')
compileOnly group: 'com.google.code.gson', name: 'gson', version: gsonVersion
implementation group: 'org.apache.httpcomponents', name: 'httpclient', version: httpClientVersion

testImplementation 'org.mock-server:mockserver-netty:5.15.0'
}

task exhaustiveTest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void tearDown() {
@Test
public void testDefaultConfiguration() {
OptimizelyHttpClient.Builder builder = builder();
assertEquals(builder.validateAfterInactivity, 5000);
assertEquals(builder.validateAfterInactivity, 1000);
assertEquals(builder.maxTotalConnections, 200);
assertEquals(builder.maxPerRoute, 20);
assertNull(builder.customRetryHandler);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void testBuilderWithCustomHttpClient() {
@Test
public void testBuilderWithDefaultHttpClient() {
AsyncEventHandler.Builder builder = builder();
assertEquals(builder.validateAfterInactivity, 5000);
assertEquals(builder.validateAfterInactivity, 1000);
assertEquals(builder.maxTotalConnections, 200);
assertEquals(builder.maxPerRoute, 20);

Expand Down

0 comments on commit dc7e901

Please sign in to comment.