Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #2

Merged
merged 2 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,13 @@ jobs:
uses: actions/setup-python@v3
with:
python-version: "3.9"

- name: Build
run: |
sudo apt update
sudo apt install -y build-essential libffi-dev xz-utils powershell curl wget gnupg apt-transport-https
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
export PATH="/root/.cargo/bin:${PATH}"
export PATH="/root/.local/bin:$PATH"
cd src/munchkin
MK_DOWNLOAD_LLVM=true pwsh ./build.ps1
6 changes: 3 additions & 3 deletions development.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### Rust++
### R++

Our Rust code is actually more like C++ due to some fun pointer manipulation we do and heavily interlinked data structures.

Expand All @@ -15,6 +15,6 @@ Except if you steal a reference, then it's on you to make sure the memory is not
Otherwise you can just write Rust as normal, and anything not within a smart-pointer still has the usual rules.

Note: If you are concerned about this or are surprised it works at all - raw pointers have special designation, specially those in `UnsafeCell`'s.
We are leaning upon some pretty niche documented constraints to keep within the bounds of Rusts expectations, if barely, but they are all official.
We are leaning upon some pretty niche documented constraints to keep within the bounds of Rusts expectations, if barely.

The language _almost_ works for what we need, so we bend it to meet that.
We'll be keeping to this model until some of Rusts systems improve enough that we don't need oto.
1 change: 1 addition & 0 deletions src/munchkin/tests/qsharp/qaoa/QAOA.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<QirGeneration>true</QirGeneration>
<QscVerbosity>Detailed</QscVerbosity>
<RuntimeIdentifier Condition="'$(RuntimeIdentifier)' == ''">$(NETCoreSdkRuntimeIdentifier)</RuntimeIdentifier>
<AssemblyName>qaoa</AssemblyName>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading
Loading