First custom-metrics-python-SDK asset release #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oheimburger
requested changes
Jul 21, 2023
|
|
||
| # Vars: | ||
| # Replace here with your tenancy's root compartment OCID | ||
| compartment_ocid = "ocid1.tenancy.oc1....." |
There was a problem hiding this comment.
Make this configurable. Config file or parameter.
| print(list_availability_domains_response.data) | ||
|
|
||
| # Initialize service client with default config file | ||
| monitoring_client = oci.monitoring.MonitoringClient(config,service_endpoint="https://telemetry-ingestion.eu-frankfurt-1.oraclecloud.com") |
| # Posting custom metrics to oci monitoring for each of the metrics (max, used, available) | ||
|
|
||
| # Max limit | ||
| post_metric_data_response = monitoring_client.post_metric_data( |
There was a problem hiding this comment.
This code is a duplicate (essentially six times) with a single change (name). Create a function for that and provide the change only. Much easier to read and maintain.
...tom-metric-python-SDK-services-limit-monitoring/files/Scripts/postServiceLimitsMetricsIAM.py
Show resolved
Hide resolved
|
|
||
| # Vars: | ||
| # Replace here with your tenancy's root compartment OCID | ||
| compartment_ocid = "ocid1.tenancy.oc1....." |
|
|
||
| # Initialize service client with default config file | ||
| #monitoring_client = oci.monitoring.MonitoringClient(config={}, signer=signer) | ||
| monitoring_client = oci.monitoring.MonitoringClient(config={},service_endpoint="https://telemetry-ingestion.eu-frankfurt-1.oraclecloud.com",signer=signer) |
There was a problem hiding this comment.
Is that generic or should it be customizable?
| print ("Service: ", s_name, "Limit: ", l_name, "Scope: ", l_scope) | ||
|
|
||
| # If the resource limit has an AD scope, we have to specify the AD or we'll get an API 400 response | ||
| if l_scope == "AD" : |
There was a problem hiding this comment.
Same comment as for postServiceLimitsMetricsIAM.py apply here. Do some factoring to reduce the code duplication and potential oversights.
oheimburger
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!,
I'm just publishing the "Using python SDK to create OCI Monitoring custom metric namespace: Services Limit monitoring example use case" initial release with the IAM user principal python script.
I want to test the process for code review @oheimburger. Once I've survived to the falcon eye ;-), I'll publish a secondary script with using Instance Principals with a secondary review of the contents.
@NicolaCimitile, have a look to the structure and let me know your thoughts.
Thanks a lot in advance to both.
Rgds.
Pablo