Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
VipulMascarenhas committed Dec 10, 2024
1 parent 6490395 commit e203222
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 12 deletions.
10 changes: 4 additions & 6 deletions ads/aqua/evaluation/evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,10 @@ def create(
),
),
tags={
**{
"aqua_evaluation": Tags.AQUA_EVALUATION,
"evaluation_job_id": evaluation_job.id,
"evaluation_source": create_aqua_evaluation_details.evaluation_source_id,
"evaluation_experiment_id": experiment_model_version_set_id,
},
"aqua_evaluation": Tags.AQUA_EVALUATION,
"evaluation_job_id": evaluation_job.id,
"evaluation_source": create_aqua_evaluation_details.evaluation_source_id,
"evaluation_experiment_id": experiment_model_version_set_id,
**evaluation_model_freeform_tags,
**evaluation_model_defined_tags,
},
Expand Down
10 changes: 4 additions & 6 deletions ads/aqua/finetuning/finetuning.py
Original file line number Diff line number Diff line change
Expand Up @@ -477,12 +477,10 @@ def create(
),
),
tags={
**{
"aqua_finetuning": Tags.AQUA_FINE_TUNING,
"finetuning_job_id": ft_job.id,
"finetuning_source": source.id,
"finetuning_experiment_id": experiment_model_version_set_id,
},
"aqua_finetuning": Tags.AQUA_FINE_TUNING,
"finetuning_job_id": ft_job.id,
"finetuning_source": source.id,
"finetuning_experiment_id": experiment_model_version_set_id,
**model_freeform_tags,
**model_defined_tags,
},
Expand Down

0 comments on commit e203222

Please sign in to comment.