-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ODSC-65517] Support freeform and defined tags for resource creation in Aqua #1021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add tags to handlers. However It can be done in a separate ticket.
|
|
|
@mrDzurb yes, missed that earlier. I've added it in this PR itself since we only have to add them for model/deployment handlers. Eval and FT already should be able to take in that input, we can do the same for model/deployment in subsequent updates. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comment questions only
Description
This PR supports defined and freeform tags as inputs when creating resources in AI Quick Actions. The following have been updated:
Following changes will be a part of subsequent PR:
Note:
hpo tests were failing since scikit-learn has updated
fit_params
toparams
insklearn.model_selection.cross_validate
, andsktime
has restricted thescikit-learn
version to<1.6.0
. We can relax the scikit-learn version once this restriction is removed.Testing
Model is created with the above freeform and defined tags.
Deployment is created with the above freeform and defined tags. If same tags are present in the model, them they are copied to the deployment but overridden with new values.
MVS, Model, Job and Job Run are created with the above freeform and defined tags.
MVS, Model, Job and Job Run are created with the above freeform and defined tags.