Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ADS docs #1022

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated ADS docs #1022

wants to merge 4 commits into from

Conversation

lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Dec 11, 2024

Updated ADS docs

  • Updated langchain doc to use generic classes and added example for default_headers
  • Added note to use AQUA in Large Language Model
Screenshot 2024-12-10 at 9 11 40 PM Screenshot 2024-12-10 at 9 12 58 PM Screenshot 2024-12-10 at 9 13 10 PM Screenshot 2024-12-10 at 9 13 27 PM

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 11, 2024
qiuosier
qiuosier approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@qiuosier qiuosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think showing default_headers here is unnecessary as no other values can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiuosier qiuosier qiuosier approved these changes

@mrDzurb mrDzurb mrDzurb approved these changes

@darenr darenr Awaiting requested review from darenr darenr is a code owner

@mayoor mayoor Awaiting requested review from mayoor mayoor is a code owner

@VipulMascarenhas VipulMascarenhas Awaiting requested review from VipulMascarenhas VipulMascarenhas is a code owner

@ahosler ahosler Awaiting requested review from ahosler ahosler is a code owner

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lu-ohai @mrDzurb @qiuosier