Fix/GenericModel.from_model_deployment() fails to load model back
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
mingkang111
requested review from
jdesanto,
mrDzurb,
qiuosier,
z7ye and
lu-ohai
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
approved these changes
Sep 12, 2023
z7ye
approved these changes
Sep 12, 2023
mingkang111
deleted the
fix/odsc_4919_genericmodel_from_model_deployment
branch
lu-ohai
pushed a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira: https://jira.oci.oraclecorp.com/browse/ODSC-46919
Failed to load model from given model deployment ocid. The root cause of it is that The
propertiesof the model_deployment object have not been constructed correctly. It only containsdisplayName.To fix it, we need to pass the oci_model get from
OCIDataScienceModelDeployment.from_id(id)into the constructor of ModelDeployment to get full properties.Changed
Pass the oci_model get from
OCIDataScienceModelDeployment.from_id(id)into the constructor of ModelDeployment.pre-commit
Test
from_model_deployment()from_id()