Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pipeline step to dict #325

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Fixed pipeline step to dict #325

merged 4 commits into from
Sep 21, 2023

Conversation

lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Sep 11, 2023 •
edited
Loading

Fixed pipeline step to dict

  • There is one bug reported by customer when calling pipeline_step.to_dict(). The environmentVariables, commandLineArguments and maximumRuntimeInMinutes are missing when pipeline_step's type is ML_JOB

Notebook

Screenshot 2023-09-11 at 4 22 33 PM

@lu-ohai lu-ohai requested review from mrDzurb and qiuosier September 11, 2023 20:21
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 11, 2023
@github-actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-31.21%

@mrDzurb
Copy link
Member

mrDzurb commented Sep 12, 2023

Looks like some tests need to be fixed.

@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-68.46%

2 similar comments
@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-68.46%

@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-68.46%

@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

1 similar comment
@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai lu-ohai added the bug Something isn't working label Sep 13, 2023
@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-68.49%

1 similar comment
@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-68.49%

@lu-ohai lu-ohai force-pushed the ODSC-47079/fixed_pipeline_step_to_dict branch from 7af1d2c to 1367e4c Compare September 14, 2023 20:47
@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-68.49%

@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-71.19%

@lu-ohai lu-ohai merged commit c533e2e into main Sep 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiuosier qiuosier qiuosier approved these changes

@mrDzurb mrDzurb mrDzurb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lu-ohai @mrDzurb @qiuosier