Moved geopandas file load out of constructor #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
|
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
darenr
previously approved these changes
Sep 19, 2023
mrDzurb
reviewed
Sep 21, 2023
|
📌 Cov diff with main: 📌 Overall coverage: |
darenr
approved these changes
Sep 21, 2023
liudmylaru
approved these changes
Sep 21, 2023
|
📌 Cov diff with main: 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADSDataset fails without geopandas installation because its parent class PandasDataset attempts to load a file using geopandas in the constructor. The file is only used in a plot method. This PR moves the geopandas load to the plot routine where it used and adds protection so that it will only be loaded once.
There are no functionality changes.
Jira: https://jira.oci.oraclecorp.com/browse/ODSC-47518