-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests to run with instance_principal #339
Merged
liudmylaru
merged 15 commits into
main
from
ODSC-47592/fix_int_test_jobs_python_runtime
Nov 14, 2023
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4f27300
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 54b53d9
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 22efebb
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru c4e5e7f
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 969e15d
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 0310b04
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru e44ff80
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru e01dfd3
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 92f88a9
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 7fdf734
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 5455bfb
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 78fb596
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 30dff05
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru f58cdc5
ODSC-47592. Fix test_jobs_python_runtime.py
liudmylaru 4acee25
Merge branch 'main' into ODSC-47592/fix_int_test_jobs_python_runtime
liudmylaru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to check on the "oci://"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied lines 94-99 (https://github.com/oracle/accelerated-data-science/blob/main/ads/jobs/serializer.py#L94-L99) from the same file, I think QQ told me he forgot to add this code here also. So my answer to your question - I do not know :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the uri does not start with oci://, the config and signer are not needed. Also we don't want to send the credentials to non-oci server (which could be a security issue).