-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for customizing path for job mount file system #368
Added support for customizing path for job mount file system #368
Conversation
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
@@ -47,6 +48,25 @@ def update_from_dsc_model(cls, dsc_model) -> dict: | |||
""" | |||
pass | |||
|
|||
@staticmethod | |||
def get_destination_path_and_name(dest: str) -> (str, str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrDzurb Thanks, this makes it easier! Just updated the code
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
…ence into ODSC-47899/allow_customize_destination_folder_job_mount
Added support for customizing path for job mount file system
/mnt
and now we added support for customizing the destination path in the format:"dest" : "<destination_path>/<destination_directory_name>"
** dir - "fss" & path - "/opc" : mount happens under "/opc/fss"
** dir - "fss" & path - "/" : mount happens under "/fss"
** dir - "fss" & path - omitted : mount happens under "/mnt/fss" (for backward compatibility of current users)
User experience
The file system will be mounted to the
test_directory_name
folder under/test_path
.The file system will be mounted to the
test_directory_name
folder under/
.The file system will be mounted to the
test_directory_name
folder under/mnt
.