Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODSC-58449: ads LangChain plugin update #877

Merged
merged 5 commits into from
Jun 18, 2024
Merged

ODSC-58449: ads LangChain plugin update #877

merged 5 commits into from
Jun 18, 2024

Conversation

mingkang111
Copy link
Member

Description

We would like to relax langchain-core version restriction:

  • 0.1.51 improve the serialization by saving model parameters. ( <= 0.1.50, the serialized object will not contain model parameters)

For gen ai plugin, we are going to put deprecation warning and point user to their own support in langchain.

Test

Screenshot 2024-06-07 at 14 00 29

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 10, 2024
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-50%

📌 Overall coverage:

Coverage-61.49%

@mingkang111 mingkang111 enabled auto-merge (squash) June 18, 2024 16:18
@mingkang111 mingkang111 merged commit 3f5ff91 into main Jun 18, 2024
2 of 3 checks passed
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@mingkang111 mingkang111 deleted the langchain_plugin_update branch June 18, 2024 16:19
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-50%

📌 Overall coverage:

Coverage-61.53%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VipulMascarenhas VipulMascarenhas VipulMascarenhas approved these changes

@mrDzurb mrDzurb mrDzurb approved these changes

@darenr darenr Awaiting requested review from darenr darenr is a code owner

@mayoor mayoor Awaiting requested review from mayoor mayoor is a code owner

@qiuosier qiuosier Awaiting requested review from qiuosier qiuosier is a code owner

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingkang111 @mrDzurb @VipulMascarenhas