Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support #887

Merged
merged 24 commits into from
Jun 27, 2024
Merged

Python 3.11 support #887

merged 24 commits into from
Jun 27, 2024

Conversation

liudmylaru
Copy link
Member

Description

ADS to support Python3.11. Jira: https://jira.oci.oraclecorp.com/browse/ODSC-54710

- initial commit - moving some code from ODSC-54710/python311_312_support branch
- removed dask from dependencies and tests
- add tf-keras for backwards-compatible
- fix for np.NaN, which removed in Numpy2.0 for poy3.9+ tests
- add tf-keras for backwards-compatible
- revert nan to NaN and fix numpy version to be less 2.0.0
- add logging for exception details in to_onnx to see more information about error
- revert nan to NaN and fix numpy version to be less 2.0.0
# Conflicts:
#	pyproject.toml
- merge main to current branch
- keep onnxruntime <1.16.0
- fix onnxruntime==1.15.1 same as Oracle Database
- fix onnxruntime~1.15.1 same as Oracle Database
- set onnxruntime~=1.15.1
- set onnxruntime~=1.15.1
- set onnx<=1.14.0
- try all unitary test with python3.9
- set "tensorflow<=2.15.1"
- set "geopandas<1.0.0"
# Conflicts:
#	test-requirements.txt
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 25, 2024
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

darenr
darenr previously approved these changes Jun 25, 2024
Copy link
Member

@darenr darenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of inline comments that I noticed. This is super fast work, thanks.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-61.53%

- removed kubernetes from [testsuite]
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-61.52%

- forecast needs compatible automlx for oy3.11
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-61.53%

Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.66%

mrDzurb
mrDzurb previously approved these changes Jun 25, 2024
- set env PIP_EXTRA_INDEX_URL to not install nvidia with torch
- updated copyrights
- run pre-commit
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

Copy link
Member

@mrDzurb mrDzurb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merge this PR, can we smash the commits?

Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.66%

Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@liudmylaru liudmylaru merged commit e1b222b into main Jun 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants