ODSC-61571 : Add RCF Implementation #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
|
📌 Cov diff with main: 📌 Overall coverage: |
|
|
📌 Cov diff with main: 📌 Overall coverage: |
ahosler
reviewed
Aug 25, 2024
| @@ -55,6 +55,7 @@ def __init__(self, config: AnomalyOperatorConfig, datasets: AnomalyDatasets): | |||
| def generate_report(self): | |||
| """Generates the report.""" | |||
| import matplotlib.pyplot as plt | |||
| plt.rcParams.update({'figure.max_open_warning': 0}) | |||
ahosler
reviewed
Aug 25, 2024
| # Set tree parameters | ||
| num_trees = model_kwargs.get("num_trees", 200) | ||
| shingle_size = model_kwargs.get("shingle_size", None) | ||
| anamoly_threshold = model_kwargs.get("anamoly_threshold", 95) |
There was a problem hiding this comment.
should this be "anomaly_threshold" ?
ahosler
reviewed
Aug 25, 2024
| figure_blocks.append(rc.Widget(ax)) | ||
|
|
||
| blocks.append(rc.Group(*figure_blocks, label=target)) | ||
| if target in anomaly_output.list_categories(): |
There was a problem hiding this comment.
Is this a way to get rid of the "series 0" in the report?
Is there an edge case where the index column value is the same as the name of the target col?
There was a problem hiding this comment.
We are plotting for each series in the dataset, there may be edge cases where we don't have sufficient data for a particular series hence no anomaly scores, this ensures we try to plot only the series for which the anomaly scores are available.
|
codeloop
changed the title
|
|
codeloop
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
|
📌 Cov diff with main: 📌 Overall coverage: |
prasankh
reviewed
Sep 3, 2024
|
prasankh
approved these changes
Sep 16, 2024
ahosler
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODSC-61571 : Add RandomCutForest as an AD Operator model .