Introduced post processing #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasankh
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
ahosler
reviewed
Aug 29, 2024
| @@ -81,6 +81,13 @@ def _train_model(self, i, series_id, df, model_kwargs): | |||
| ) | |||
|
|
|||
| data = self.preprocess(df, series_id) | |||
| cap = data['y'].max() * 1.2 | |||
There was a problem hiding this comment.
Yes, It's mandatory with logistic growth function. Removed logistic growth function for now as it fails during generating local explanations.
| if self.spec.postprocessing.enabled: | ||
| floor = self.spec.postprocessing.steps.set_min_forecast | ||
| else: | ||
| floor = data['y'].min() * 0.8 |
There was a problem hiding this comment.
Shouldn't we leave this to the framework? Why 0,8?
There was a problem hiding this comment.
It's mandatory with logistic growth function. Removed logistic growth function for now.
| @@ -317,6 +317,25 @@ spec: | |||
| required: false | |||
| default: false | |||
|
|
|||
| postprocessing: | |||
There was a problem hiding this comment.
This is a great way to add it 👍
codeloop
previously approved these changes
Sep 2, 2024
…res to manage evaluation service configurations.
|
|
📌 Cov diff with main: 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODSC-61573
Following schema can be used to set min value for the forecast value