Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LangChain LLMs and Add Chat Models Support #953

Merged
merged 28 commits into from
Sep 30, 2024
Merged

Update LangChain LLMs and Add Chat Models Support #953

merged 28 commits into from
Sep 30, 2024

Conversation

qiuosier
Copy link
Member

@qiuosier qiuosier commented Sep 24, 2024 •
edited
Loading

This PR includes the following updates on the LangChain integration:

  • Removed supports for OCI generative AI. Users should use the implementation from langchain-community instead.
  • Compatible with LangChain v0.3 and Pydantic v2.
  • Added chat model
  • Added streaming and async support
  • Added tool calling support for vLLM

Example code to enable tool calling for mistral model

from ads.llm import ChatOCIModelDeploymentVLLM, ChatTemplates

deployment_ocid = "<Model Deployment OCID>"

llm =  ChatOCIModelDeploymentVLLM(
    model="odsc-llm", # update this as needed.
    streaming=True,
    endpoint=f"https://modeldeployment.us-ashburn-1.oci.customer-oci.com/{deployment_ocid}/predict",
    auth=ads.common.auth.default_signer(),
    model_kwargs={"temperature" : 0},
    tool_choice="auto",
    chat_template=ChatTemplates.mistral()
)

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 24, 2024
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@qiuosier qiuosier marked this pull request as draft September 24, 2024 15:18
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@qiuosier qiuosier marked this pull request as ready for review September 26, 2024 16:57
mrDzurb
mrDzurb previously approved these changes Sep 26, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-20.19%

@qiuosier qiuosier dismissed stale reviews from mrDzurb and mayoor via 8b84923 September 26, 2024 20:54
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@qiuosier
Copy link
Member Author

Test coverage:
image

@qiuosier
Copy link
Member Author

Update documentation
LangChain Integration - ADS.pdf

mayoor
mayoor previously approved these changes Sep 26, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-20.19%

@qiuosier qiuosier dismissed stale reviews from VipulMascarenhas and mayoor via 8cec512 September 27, 2024 02:09
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-20.19%

mrDzurb
mrDzurb previously approved these changes Sep 30, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-35%

📌 Overall coverage:

Coverage-59.07%

@qiuosier qiuosier merged commit 38d969c into main Sep 30, 2024
24 checks passed
This was referenced Sep 30, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VipulMascarenhas VipulMascarenhas VipulMascarenhas approved these changes

@mrDzurb mrDzurb mrDzurb approved these changes

@mayoor mayoor mayoor left review comments

@darenr darenr Awaiting requested review from darenr darenr is a code owner

@ahosler ahosler Awaiting requested review from ahosler ahosler is a code owner

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiuosier @mayoor @mrDzurb @VipulMascarenhas