Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sf merlion for time-based and forecast AD #956

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Add sf merlion for time-based and forecast AD #956

merged 12 commits into from
Oct 22, 2024

Conversation

codeloop
Copy link
Member

@codeloop codeloop commented Sep 29, 2024 •
edited
Loading

Add support for salesforce merlion model for time-based and forecast anomaly detection.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 29, 2024
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-60.43%

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-60.44%

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@codeloop codeloop changed the title Add sf merlion for time-based ad Add sf merlion for time-based and forecast ad Sep 30, 2024
@codeloop codeloop changed the title Add sf merlion for time-based and forecast ad Add sf merlion for time-based and forecast AD Sep 30, 2024
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@codeloop codeloop marked this pull request as ready for review September 30, 2024 06:31
@codeloop codeloop requested a review from prasankh September 30, 2024 06:31
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-60.43%

ahosler
ahosler previously requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ahosler ahosler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In testing, I see that the anomaly score is no longer normalized from 0-1. Does Merlion have a different interpretation for the meaning of this score ? (CSV uploaded below)
    I believe we should stick with the [0,1] convention unless we have good reason to change.

  2. Also Merlion seemed over-reactive on a few of the tests I've run. Are there any default settings we should be tweaking?

  3. Could Merlion be made to work for non-timeseries AD? Or is it primarily time-based?

outliers.csv

pyproject.toml Show resolved Hide resolved
ads/opctl/operator/lowcode/anomaly/schema.yaml Outdated Show resolved Hide resolved
ads/opctl/operator/lowcode/anomaly/model/randomcutforest.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-58.94%

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-58.95%

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@codeloop codeloop enabled auto-merge October 17, 2024 10:58
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-58.96%

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@codeloop
Copy link
Member Author

codeloop commented Oct 17, 2024 •
edited
Loading

  1. In testing, I see that the anomaly score is no longer normalized from 0-1. Does Merlion have a different interpretation for the meaning of this score ? (CSV uploaded below)
    I believe we should stick with the [0,1] convention unless we have good reason to change.
  2. Also Merlion seemed over-reactive on a few of the tests I've run. Are there any default settings we should be tweaking?
  3. Could Merlion be made to work for non-timeseries AD? Or is it primarily time-based?

outliers.csv

  1. Added score normalization.
  2. We can use an alarm threshold param to control the sensitivity of the models.
  3. Currently it only supports time-series data.

@codeloop codeloop requested a review from ahosler October 17, 2024 16:46
@codeloop codeloop dismissed ahosler’s stale review October 17, 2024 16:48

Update the PR

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-58.95%

@github-actions GitHub Actions
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-58.95%

@codeloop codeloop merged commit a0efd38 into main Oct 22, 2024
24 checks passed
@ahosler ahosler deleted the feature/ad_merlion branch October 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahosler ahosler ahosler approved these changes

@prasankh prasankh prasankh approved these changes

@darenr darenr Awaiting requested review from darenr darenr is a code owner

@mayoor mayoor Awaiting requested review from mayoor mayoor is a code owner

@mrDzurb mrDzurb Awaiting requested review from mrDzurb mrDzurb is a code owner

@VipulMascarenhas VipulMascarenhas Awaiting requested review from VipulMascarenhas VipulMascarenhas is a code owner

@qiuosier qiuosier Awaiting requested review from qiuosier qiuosier is a code owner

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeloop @prasankh @ahosler