Support for Private Endpoint on Model Deployment and AQUA MD #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
lu-ohai
changed the title
…ence into ODSC-64017/add_private_endpoint_for_md
|
📌 Cov diff with main: 📌 Overall coverage: |
1 similar comment
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
lu-ohai
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
lu-ohai
changed the title
ads/aqua/modeldeployment/entities.py
Outdated
| @@ -98,6 +99,9 @@ def from_oci_model_deployment( | |||
| freeform_tags = oci_model_deployment.freeform_tags or UNKNOWN_DICT | |||
| aqua_service_model_tag = freeform_tags.get(Tags.AQUA_SERVICE_MODEL_TAG, None) | |||
| aqua_model_name = freeform_tags.get(Tags.AQUA_MODEL_NAME_TAG, UNKNOWN) | |||
| private_endpoint_id = ( | |||
| getattr(oci_model_deployment.model_deployment_configuration_details.model_configuration_details.instance_configuration, "private_endpoint_id", UNKNOWN) | |||
There was a problem hiding this comment.
nit: create a "private_endpoint_id" const.
mrDzurb
reviewed
Oct 24, 2024
ads/aqua/modeldeployment/entities.py
Outdated
| @@ -98,6 +99,9 @@ def from_oci_model_deployment( | |||
| freeform_tags = oci_model_deployment.freeform_tags or UNKNOWN_DICT | |||
| aqua_service_model_tag = freeform_tags.get(Tags.AQUA_SERVICE_MODEL_TAG, None) | |||
| aqua_model_name = freeform_tags.get(Tags.AQUA_MODEL_NAME_TAG, UNKNOWN) | |||
| private_endpoint_id = ( | |||
| getattr(oci_model_deployment.model_deployment_configuration_details.model_configuration_details.instance_configuration, "private_endpoint_id", UNKNOWN) | |||
There was a problem hiding this comment.
Do you have pre-commit installed? Looks like a wrong formatting.
There was a problem hiding this comment.
Just updated the format.
ads/aqua/modeldeployment/entities.py
Outdated
| @@ -47,6 +47,7 @@ class AquaDeployment(DataClassSerializable): | |||
| created_on: str = None | |||
| created_by: str = None | |||
| endpoint: str = None | |||
| private_endpoint_id: str = None | |||
| console_link: str = None | |||
| lifecycle_details: str = None | |||
| shape_info: field(default_factory=ShapeInfo) = None | |||
There was a problem hiding this comment.
This
shape_info: field(default_factory=ShapeInfo) = None
Should be changed on
shape_info: ShapeInfo = field(default_factory=ShapeInfo)
ads/aqua/modeldeployment/entities.py
Outdated
| @@ -98,6 +99,9 @@ def from_oci_model_deployment( | |||
| freeform_tags = oci_model_deployment.freeform_tags or UNKNOWN_DICT | |||
| aqua_service_model_tag = freeform_tags.get(Tags.AQUA_SERVICE_MODEL_TAG, None) | |||
| aqua_model_name = freeform_tags.get(Tags.AQUA_MODEL_NAME_TAG, UNKNOWN) | |||
| private_endpoint_id = ( | |||
| getattr(oci_model_deployment.model_deployment_configuration_details.model_configuration_details.instance_configuration, "private_endpoint_id", UNKNOWN) | |||
There was a problem hiding this comment.
Looks like we use model_configuration_details multiple times inside this method. I would suggest to do something like this:
model_configuration_details = oci_model_deployment.model_deployment_configuration_details.model_configuration_details
environment_configuration_details = oci_model_deployment.model_deployment_configuration_details.environment_configuration_details
and then everywhere
getattr(model_configuration_details.instance_configuration, "private_endpoint_id", UNKNOWN)
....
mrDzurb
reviewed
Oct 24, 2024
| oci.data_science.models.InstanceConfiguration, "private_endpoint_id" | ||
| ): | ||
| raise EnvironmentError( | ||
| "Private endpoint is not supported in the current OCI SDK installed." |
There was a problem hiding this comment.
Would be nice to tell, which minimum version of the SDK can be used.
There was a problem hiding this comment.
Added theTODO in the comments.
mrDzurb
previously approved these changes
Oct 24, 2024
VipulMascarenhas
previously approved these changes
Oct 24, 2024
|
📌 Cov diff with main: 📌 Overall coverage: |
lu-ohai
dismissed stale reviews from VipulMascarenhas and mrDzurb
via
30b8bcf
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
approved these changes
Oct 25, 2024
VipulMascarenhas
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Private Endpoint on Model Deployment and AQUA MD
with_private_endpoint_idonModelDeploymentInfrastructureclass to enable configure private endpoint for model deploymentNotebook