-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no lon… #2796
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving... a few comments on copyrights (of course!) and a suggestion to look at each usage of the word "Docker" to see if it can be made generic for any container environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed all comments
WLST_HOME=${ORACLE_HOME}/oracle_common/common/bin | ||
echo "WLST_HOME=${WLST_HOME}" | ||
|
||
DOMAIN_HOME=${ORACLE_HOME}/user_projects/domains/${DOMAIN_NAME} | ||
DOMAIN_HOME=${ORACLE_HOME}/ohssa/user_projects/domains/${DOMAIN_NAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of $ORACLE_HOME is /u01/oracle/ohssa. So, I think that the old value was correct.
cp -L /u01/oracle/config/moduleconf/*.conf ${DOMAIN_HOME}/config/fmwconfig/components/OHS/$OHS_COMPONENT_NAME/moduleconf && find ${DOMAIN_HOME}/config/fmwconfig/components/OHS/$OHS_COMPONENT_NAME/moduleconf -print0 -name '.*' | xargs rm -rf | ||
|
||
conf=$(ls -l /u01/oracle/config/httpd/*.conf 2>/dev/null | wc -l) | ||
if [ $conf -gt 0 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if there are no files there would be 1 line; so I think it should be compared with 1.
fi | ||
|
||
htdocs=$(ls -l /u01/oracle/config/htdocs/*.html 2>/dev/null | wc -l) | ||
if [ $htdocs -gt 0 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as line no. 113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into my comments.
Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no longer supported.
Making changes container-scripts so that things like the Domain_HOME come from the environment variable.
Create 12.2.1.4 sample for patching