-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert LDAP authorization plugin configuration to YAML #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jul 22, 2024
vladak
force-pushed
the
ldap_plugin_config_yaml
branch
from
August 1, 2024 11:17
7dc2c07
to
067e135
Compare
ginoaugustine
previously approved these changes
Aug 2, 2024
vladak
force-pushed
the
ldap_plugin_config_yaml
branch
from
August 2, 2024 21:57
067e135
to
c0884ab
Compare
https://github.com/oracle/opengrok/wiki/Authorization-plugins#ldap-setup will have to be updated once this is merged in. |
vladak
force-pushed
the
ldap_plugin_config_yaml
branch
from
August 12, 2024 13:25
c0884ab
to
5f69059
Compare
Example multi-server configuration: servers:
- url: "ldaps://ldap-foo.example.com"
username: cn=admin,ou=admins,dc=example,dc=com
password: changeme
- url: "ldaps://ldap-bar.example.com"
username: cn=admin,ou=admins,dc=example,dc=com
password: changeme
interval: 900000
countLimit: 3
connectTimeout: 3000
readTimeout: 3000
searchTimeout: 1000
searchBase: dc=example,dc=com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little brother of #2329, just for the LDAP authorization plugins. I have chosen YAML.
I had to select the members by hand via tha
@JsonProperty
, otherwise this leads to stack overflow via infinite recursion by callingLdapServer#isWorking()
from the Jackson serialization methods.The integer fields not present in the configuration are deserialized to zero values,
opengrok/plugins/src/main/java/opengrok/auth/plugin/ldap/LdapServer.java
Lines 261 to 266 in 953e10a
This will also help with the stability of the tests, as I have seen
plugins/src/test/java/opengrok/auth/plugin/configuration/ConfigurationTest.java
fail in the same way as the indexer configuration (#4441).