-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Hash#except #2463
Implement Hash#except #2463
Conversation
Can we untag anything, or is that not possible until we declare the new version? |
Yes, using Except you need to s/2.7/3.0/ and s/2.6/2.7/ in those docs (I'll try to update them soon, also need to update |
@wildmaples Could you add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks good.
I'll try to make spec/truffleruby.mspec
use the union merge to avoid the conflict.
@wildmaples Could you rebase against latest master? |
2aa635a
to
ddd17c1
Compare
@@ -95,6 +95,7 @@ class MSpecScript | |||
# Use spec/ruby/core/nil/nil_spec.rb as a dummy file to avoid being empty | |||
set :next, %w[ | |||
spec/ruby/core/nil/nil_spec.rb | |||
spec/ruby/core/hash/except_spec.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this since RUBY_VERSION is 3.0.2 on master now, but no big deal I'll just have a commit on top to revert this small change.
Instead we want to jt untag spec/ruby/core/hash/except_spec.rb
, I'll do that on top.
PullRequest: truffleruby/2999
Part of the Ruby 3.0 support - #2453 😊
I followed the specs in - ruby/spec#786