Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hash#except #2463

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Implement Hash#except #2463

merged 3 commits into from
Oct 22, 2021

Conversation

wildmaples
Copy link
Contributor

Part of the Ruby 3.0 support - #2453 😊
I followed the specs in - ruby/spec#786

@chrisseaton
Copy link
Collaborator

Can we untag anything, or is that not possible until we declare the new version?

@eregon
Copy link
Member

eregon commented Oct 9, 2021

Can we untag anything, or is that not possible until we declare the new version?

Yes, using :next and PRETEND_RUBY_VERSION: https://github.com/oracle/truffleruby/blob/master/doc/contributor/workflow.md#running-specs-for-ruby-27-features

Except you need to s/2.7/3.0/ and s/2.6/2.7/ in those docs (I'll try to update them soon, also need to update updating-ruby.md to remind updating that section).

@eregon eregon mentioned this pull request Oct 9, 2021
82 tasks
@eregon
Copy link
Member

eregon commented Oct 11, 2021

@wildmaples Could you add except_spec.rb to :next and ensures it passes?

@wildmaples wildmaples requested a review from eregon October 13, 2021 13:54
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good.
I'll try to make spec/truffleruby.mspec use the union merge to avoid the conflict.

@eregon eregon self-assigned this Oct 13, 2021
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Oct 18, 2021
@eregon
Copy link
Member

eregon commented Oct 21, 2021

@wildmaples Could you rebase against latest master?
:next should no longer be changed (you can skip that commit) since RUBY_VERSION is 3.0.2 now.

@eregon eregon removed the in-ci The PR is being tested in CI. Do not push new commits. label Oct 21, 2021
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Oct 22, 2021
@eregon eregon added this to the 22.0.0 milestone Oct 22, 2021
@@ -95,6 +95,7 @@ class MSpecScript
# Use spec/ruby/core/nil/nil_spec.rb as a dummy file to avoid being empty
set :next, %w[
spec/ruby/core/nil/nil_spec.rb
spec/ruby/core/hash/except_spec.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this since RUBY_VERSION is 3.0.2 on master now, but no big deal I'll just have a commit on top to revert this small change.
Instead we want to jt untag spec/ruby/core/hash/except_spec.rb, I'll do that on top.

graalvmbot pushed a commit that referenced this pull request Oct 22, 2021
PullRequest: truffleruby/2999
@graalvmbot graalvmbot merged commit ddd17c1 into oracle:master Oct 22, 2021
@tomstuart tomstuart deleted the hash-except branch November 2, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-ci The PR is being tested in CI. Do not push new commits. oca-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants