Support timezone object argument to Time.{at,new} and Time#{getlocal,localtime} #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…localtime} closes oracle#1717 For compatibility with https://bugs.ruby-lang.org/issues/14850 Co-authored-by: Manef Zahra <manef.zahra@shopify.com> Co-authored-by: Patrick Lin <patrick.lin@shopify.com>
Expected TypeError ((?-mix:can't convert \w+ into an exact number)) but got: TypeError (wrong argument type Object (expected Integer))
> Expected TypeError ((?-mix:can't convert \w+ into an exact number)) > but got: TypeError (wrong argument type Object (expected Integer)) close enough
In CRuby this spec passes because it is a Time-Like object (Time::tm) that defines to_time. We are using an actual Time object here so we need the method for the spec to pass.
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Thank you! Will review the PR at this a bit later. |
|
Wondering what logic is behind the offset = as_local.utc_offset.nonzero? || as_local.to_i - time.to_iIt seems to me it should use either |
…annot be converted into numeric
…stance of Time and take into account #utc_offset
andrykonchin
approved these changes
Dec 24, 2024
andrykonchin
added
the
in-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds (at least some) support for the "Timezone Objects" interfaces to several
Timemethods as described inhttps://docs.ruby-lang.org/en/3.3/Time.html#class-Time-label-Timezone+Objects
It was difficult to discern how it all should work but between the CRuby source code and the specs (and tracing what methods were being called on our objects) I think we figured it out.
We started this six months ago as part of HackDays and didn't get very far, then I resurrected it this week.
closes #1717