Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(go): shift Go support window to [1.22, 1.23] #820

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Aug 30, 2024

  1. Upgrading go.mod to 1.22
  2. Using new for syntax like for i := range N
  3. Migrating random generator from package math/rand to package math/rand/v2

References:

Resolves: #812

@Wwwsylvia Wwwsylvia added the dependencies Pull requests that update a dependency file label Aug 30, 2024
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (606f636) to head (62b3113).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   77.94%   77.90%   -0.05%     
==========================================
  Files          63       63              
  Lines        4698     4698              
==========================================
- Hits         3662     3660       -2     
- Misses        656      657       +1     
- Partials      380      381       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

registry/remote/retry/policy.go Outdated Show resolved Hide resolved
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 70d98dd into oras-project:main Sep 2, 2024
9 checks passed
@Wwwsylvia Wwwsylvia deleted the bump_go branch September 2, 2024 05:30
Wwwsylvia added a commit that referenced this pull request Sep 2, 2024
Minor refactor for #820

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift Go Support Window to [1.22, 1.23]
2 participants