Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update example for oras push #1102

Merged
merged 4 commits into from
Sep 1, 2023
Merged

doc: update example for oras push #1102

merged 4 commits into from
Sep 1, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Sep 1, 2023

This PR updates example for oras push command.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM but it seems we miss an example of setting artifact type.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/root/push.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #1102 (4ee78eb) into main (5e98cec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   80.28%   80.31%   +0.02%     
==========================================
  Files          57       57              
  Lines        2927     2931       +4     
==========================================
+ Hits         2350     2354       +4     
  Misses        398      398              
  Partials      179      179              
Files Changed Coverage Δ
cmd/oras/root/push.go 78.45% <100.00%> (+0.48%) ⬆️

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit b8db4fb into oras-project:main Sep 1, 2023
6 checks passed
@qweeah qweeah deleted the example branch September 1, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants