Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "perf: optimize request count for manifest and blob deletion" #1115

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Sep 12, 2023

Reverts #1109

@qweeah qweeah changed the title Revert "perf: optimize request count for manifest and blob deletion" revert: "perf: optimize request count for manifest and blob deletion" Sep 12, 2023
@shizhMSFT
Copy link
Contributor

Reverting #1109 as the previous PR was merged in the wrong way.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #1115 (af0bed7) into main (6609ecb) will decrease coverage by 0.04%.
The diff coverage is 95.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   80.40%   80.37%   -0.04%     
==========================================
  Files          57       57              
  Lines        2945     2940       -5     
==========================================
- Hits         2368     2363       -5     
  Misses        398      398              
  Partials      179      179              
Files Changed Coverage Δ
cmd/oras/root/blob/delete.go 82.60% <ø> (-0.25%) ⬇️
cmd/oras/root/manifest/delete.go 82.19% <ø> (-1.36%) ⬇️
cmd/oras/internal/option/remote.go 78.36% <75.00%> (ø)
cmd/oras/internal/option/spec.go 92.59% <100.00%> (ø)
cmd/oras/root/attach.go 82.64% <100.00%> (+0.59%) ⬆️
cmd/oras/root/push.go 78.45% <100.00%> (+0.11%) ⬆️
internal/registryutil/auth.go 100.00% <100.00%> (ø)

@qweeah qweeah force-pushed the revert-1109-qweeah/optmize-delete branch from badf0ef to af0bed7 Compare September 12, 2023 06:06
@shizhMSFT
Copy link
Contributor

#1109 will be re-created to optimize future git blame.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 07dd62a into main Sep 12, 2023
6 checks passed
@shizhMSFT shizhMSFT deleted the revert-1109-qweeah/optmize-delete branch September 12, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants