-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release ppc64le/riscv64 and improve reproducibility #1118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have verified that Linux and Windows amd64 binaries built are working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit questions.
@katexochen Could you rebase the branch so that we can merge? |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 57 57
Lines 2991 2991
=======================================
Hits 2396 2396
Misses 410 410
Partials 185 185 |
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
- trim paths - set build ID to empty string - set binary timestamp to commit timestamp - strip binary (reduces size from 9.2MB to 8.5MB) Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@shizhMSFT I rebased again, could you approve the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just sayin', this enabled Armbian building on riscv64. Armbian uses ghcr.io + ORAS for distributed builds. Thank you! 👍 |
What this PR does / why we need it:
Release for more architectures, as oras is getting more popular 🎉 and some use cases require more exotic architectures.
Also improving the reproducibility of release artifacts by
Which issue(s) this PR fixes:
Fixes #1111
Please check the following list: