Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create tty copy handler #1485

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TerryHowe
Copy link
Member

@TerryHowe TerryHowe commented Aug 19, 2024

What this PR does / why we need it:

Create tty copy handler with new StartTracking and StopTracking methods.

Partial: #1542
Closes: #1548

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (5280c67) to head (bfdc7a6).

Files with missing lines Patch % Lines
cmd/oras/internal/display/status/tty.go 86.66% 3 Missing and 1 partial ⚠️
cmd/oras/root/cp.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   83.99%   84.14%   +0.14%     
==========================================
  Files         119      119              
  Lines        5306     5309       +3     
==========================================
+ Hits         4457     4467      +10     
+ Misses        602      598       -4     
+ Partials      247      244       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TerryHowe TerryHowe force-pushed the tty-copy-handler branch 7 times, most recently from 9676775 to dca91a9 Compare August 22, 2024 13:32
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale Inactive issues or pull requests label Nov 12, 2024
@TerryHowe TerryHowe removed the stale Inactive issues or pull requests label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor oras cp to use handlers for command output
1 participant