Switch SendGrid Email Notification to AWS SnS #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyuvaraaj
requested review from
skanderm,
micya,
scottveirs and
dthaler
as code owners
|
Thanks for this! I won't speak to the code itself, since that's not my area for this project, but I had actually misspoken and references to |
added 2 commits
September 18, 2024 11:42
micya
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Please check with @scottveirs on the appropriate AWS account/billing.
added 3 commits
September 18, 2024 13:11
This reverts commit 5733a59.
micya
previously approved these changes
Sep 18, 2024
dthaler
reviewed
Sep 18, 2024
dthaler
reviewed
Sep 18, 2024
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
reviewed
Sep 18, 2024
dthaler
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188 Throttling to 14 email request per second implementation pending.