Update tests, move updating candidate on detection submission to its …

…own action

server/lib/orcasite/radio/detection.ex

@@ -69,6 +69,10 @@ defmodule Orcasite.Radio.Detection do
  authorize_if always()
  end
 
+ bypass action(:update_candidate) do
+ authorize_if always()
+ end
+
  policy changing_attributes([:visible]) do
  authorize_if actor_attribute_equals(:moderator, true)
  end
@@ -131,6 +135,13 @@ defmodule Orcasite.Radio.Detection do
  change manage_relationship(:candidate, type: :append)
  end
 
+ update :update_candidate do
+ argument :candidate, :map
+ require_atomic? false
+
+ change manage_relationship(:candidate, type: :append)
+ end
+
  update :set_visible do
  accept [:visible]
  require_atomic? false
@@ -254,7 +265,7 @@ defmodule Orcasite.Radio.Detection do
  end
 
  detection
- |> Ash.Changeset.for_update(:update, %{candidate: candidate})
+ |> Ash.Changeset.for_update(:update_candidate, %{candidate: candidate})
  |> Ash.update()
  end)
  |> Ash.Changeset.after_action(fn changeset, detection ->

server/lib/orcasite/radio/workers/link_feed_stream.ex

@@ -8,7 +8,7 @@ defmodule Orcasite.Radio.Workers.LinkFeedStream do
  ]
 
  @impl Oban.Worker
- def perform(%Oban.Job{args: %{"feed_stream_id" => nil} = args}) do
+ def perform(%Oban.Job{args: %{"feed_stream_id" => nil}}) do
  :ok
  end
 

server/test/orcasite_web/graphql/moderator_test.exs

@@ -32,7 +32,7 @@ defmodule OrcasiteWeb.ModeratorTest do
  slug: "orcasound-lab"
  }
  )
- |> Ash.create!()
+ |> Ash.create!(authorize?: false)
 
  detection =
  Orcasite.Radio.Detection.submit_detection(%{

server/test/orcasite_web/graphql/radio_test.exs

@@ -13,7 +13,7 @@ defmodule OrcasiteWeb.RadioTest do
  slug: "orcasound-lab"
  }
  )
- |> Ash.create!()
+ |> Ash.create!(authorize?: false)
 
  [feed: feed]
  end