Skip to content

Commit

Permalink
Move image env to prod-only in runtime with default dev config (#623)
Browse files Browse the repository at this point in the history
  • Loading branch information
skanderm authored Sep 10, 2024
1 parent cf8395a commit 72b12b8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 4 additions & 0 deletions server/config/dev.exs
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,7 @@ config :ex_aws,
:instance_role
],
region: "us-west-2"

config :orcasite,
audio_image_bucket: System.get_env("ORCASITE_AUDIO_IMAGE_BUCKET", "dev-audio-viz"),
audio_image_bucket_region: System.get_env("ORCASITE_AUDIO_IMAGE_BUCKET_REGION", "us-west-2")
9 changes: 5 additions & 4 deletions server/config/runtime.exs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ import Config
# Alternatively, you can use `mix phx.gen.release` to generate a `bin/server`
# script that automatically sets the env var above.

config :orcasite,
audio_image_bucket: System.get_env("ORCASITE_AUDIO_IMAGE_BUCKET", "audio-deriv-orcasound-net"),
audio_image_bucket_region: System.get_env("ORCASITE_AUDIO_IMAGE_BUCKET_REGION", "us-west-2")

if System.get_env("PHX_SERVER") do
config :orcasite, OrcasiteWeb.Endpoint, server: true
end
Expand Down Expand Up @@ -91,4 +87,9 @@ if config_env() == :prod do
end

config :swoosh, :api_client, Swoosh.ApiClient.Finch

config :orcasite,
audio_image_bucket:
System.get_env("ORCASITE_AUDIO_IMAGE_BUCKET", "audio-deriv-orcasound-net"),
audio_image_bucket_region: System.get_env("ORCASITE_AUDIO_IMAGE_BUCKET_REGION", "us-west-2")
end
1 change: 0 additions & 1 deletion server/lib/orcasite/radio/feed.ex
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ defmodule Orcasite.Radio.Feed do
on_no_match: {:create, :for_feed_segment},
on_match: :ignore
)
|> IO.inspect(label: "new change")
end)
end
end
Expand Down

0 comments on commit 72b12b8

Please sign in to comment.