Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latLng for explicit Feed geo point #154

Merged
merged 14 commits into from
Jul 28, 2023
Merged

Add latLng for explicit Feed geo point #154

merged 14 commits into from
Jul 28, 2023

Conversation

skanderm
Copy link
Contributor

No description provided.

@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 26, 2023 22:14 Inactive
@skanderm skanderm temporarily deployed to orcasite-pr-154 July 27, 2023 19:24 Inactive
@skanderm skanderm temporarily deployed to orcasite-pr-154 July 27, 2023 19:42 Inactive
paulcretu
paulcretu requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@paulcretu paulcretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change seeds
  • longitudeLatitude -> latLong
  • remove locationPoint from graphql
  • don't forget to flip coords around when deploying

@skanderm skanderm changed the title Add longitudeLatitude for explicit Feed geo point Add latitudeLongitude for explicit Feed geo point Jul 27, 2023
paulcretu
paulcretu previously approved these changes Jul 28, 2023
View reviewed changes
ui/src/components/MapLayout.tsx Outdated Show resolved Hide resolved
@skanderm @paulcretu
Update ui/src/components/MapLayout.tsx
06ac86b 
Co-authored-by: Paul Cretu <paul.s.cretu@gmail.com>
@skanderm skanderm temporarily deployed to orcasite-pr-154 July 28, 2023 00:18 Inactive
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 01:03 Inactive
@skanderm skanderm temporarily deployed to orcasite-pr-154 July 28, 2023 02:11 Inactive
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 02:31 Inactive
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 02:31 Inactive
@paulcretu paulcretu changed the title Add latitudeLongitude for explicit Feed geo point Add latLng for explicit Feed geo point Jul 28, 2023
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 02:36 Inactive
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 02:56 Inactive
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 03:25 Inactive
@paulcretu paulcretu temporarily deployed to orcasite-pr-154 July 28, 2023 03:48 Inactive
@paulcretu paulcretu merged commit 2b4a559 into main Jul 28, 2023
1 check passed
@paulcretu paulcretu deleted the skander/fix-lat-lng branch July 28, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcretu paulcretu paulcretu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skanderm @paulcretu