-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update detections and candidates #166
Conversation
…ction action/mutation
Hey @skanderm , Reviewing human detections over the weekend on the production site, I was again struck by how it often seems that the audio data presented to the moderator isn't perfectly aligned with the time the human observer heard something interesting. I wondered again if the timestamp for a detection is determined by when the "I hear something interesting" button is selected, or when the detection is submitted with the "Submit" button in the modal (e.g. after 10+ seconds of typing in the free text field)? I feel like we've discussed this before, but I can't remember the outcome... In any case, do you think for this or a next version of human annotation UI we could ensure the time stamp is established ASAP, i.e. when the user first indicates they have heard something? In the v3 UI as @paulcretu has implemented it, that would likely be the time the user first selects one of the three icons (whale, vessel, other). I guess an edge case might be a user who erroneously selects one icon (e.g. vessel), but then listens more carefully and changes to selecting another icon (e.g. whale). Even then, though, I think taking the earliest timestamp may help moderators be able to hear the earliest signals the community scientist thought were interesting. |
That's a really good point, @scottveirs! I'm currently updating the GraphQL endpoints and frontend queries. The timestamp recorded is based on whatever the frontend sends, so I'm sure we can capture the player offset at the moment the button is pushed. I'll take a look at that right after updating the GQL queries. |
Closing this PR in favor of a new one - I edited migrations and the preview app seems to be getting hung up on them. |
No description provided.