Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint-staged, husky for formatting during commits #324

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

skanderm
Copy link
Contributor

@skanderm skanderm changed the title Add lint staged, husky for formatting during commits Add lint-staged, husky for formatting during commits Jan 29, 2024
@skanderm skanderm enabled auto-merge (squash) January 29, 2024 19:43
Copy link
Member

@paulcretu paulcretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm not working for me:

>>> git commit -m "test"                                                                                                           🐙  ±:test:.
✔ Preparing lint-staged...
⚠ Running tasks for staged files...
  ❯ ui/lint-staged.config.js — 1 file
    ❯ *.{js,jsx,ts,tsx} — 1 file
      ✖ next lint --fix --file ui/src/pages/index.tsx [ENOENT]
    ❯ * — 1 file
      ✖ prettier --ignore-unknown --write [KILLED]
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ next lint --fix --file ui/src/pages/index.tsx failed without output (ENOENT).

✖ prettier --ignore-unknown --write failed without output (KILLED).
husky - pre-commit script failed (code 1)

ui/lint-staged.config.js Outdated Show resolved Hide resolved
ui/lint-staged.config.js Outdated Show resolved Hide resolved
@skanderm skanderm dismissed paulcretu’s stale review January 30, 2024 18:38

Updated this in recent commit

@paulcretu paulcretu temporarily deployed to orcasite-pr-324 January 30, 2024 23:21 Inactive
@skanderm skanderm merged commit ef38743 into main Jan 31, 2024
4 checks passed
@skanderm skanderm deleted the skander/add-lint-staged branch January 31, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lint-staged and husky
2 participants