Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record detection IP #368

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Record detection IP #368

merged 10 commits into from
Mar 27, 2024

Conversation

skanderm
Copy link
Contributor

image

@skanderm skanderm temporarily deployed to orcasite-pr-368 March 20, 2024 20:55 Inactive
Copy link
Member

@paulcretu paulcretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use this https://github.com/ajvondrak/remote_ip

Figuring out IPs from headers seems to be tricky

Also, (ideally) non-moderators shouldn't be getting IP address info in the gql request. I think this is the first time we've had to deal with this. Does ash have anything to handle access control and role-based authz?

@skanderm
Copy link
Contributor Author

I think we should use this https://github.com/ajvondrak/remote_ip

Figuring out IPs from headers seems to be tricky

Also, (ideally) non-moderators shouldn't be getting IP address info in the gql request. I think this is the first time we've had to deal with this. Does ash have anything to handle access control and role-based authz?

Good points about both. We're now using remote_ip and authorizing access to source_ip.

@skanderm skanderm enabled auto-merge (squash) March 27, 2024 17:07
@skanderm skanderm temporarily deployed to orcasite-pr-368 March 27, 2024 17:16 Inactive
@skanderm skanderm merged commit 7c111ef into main Mar 27, 2024
4 checks passed
@skanderm skanderm deleted the skander/record-detection-ip branch March 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants