-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record detection IP #368
Record detection IP #368
Conversation
skanderm
commented
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use this https://github.com/ajvondrak/remote_ip
Figuring out IPs from headers seems to be tricky
Also, (ideally) non-moderators shouldn't be getting IP address info in the gql request. I think this is the first time we've had to deal with this. Does ash have anything to handle access control and role-based authz?
Good points about both. We're now using |