Add link to reports from detection submit modal #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferent DialogTitle based on if submitted or not
paulcretu
requested changes
Mar 28, 2024
|
@paulcretu this is ready for another review |
paulcretu
approved these changes
Apr 1, 2024
paulcretu
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Thanks for the changes, looks great! I'll get it merged 🚀
Some other thoughts, not worth worrying about now but things we could do down the line:
- Might be worth refactoring the markup into just two conditional blocks (
submittedvs!submitted) - We could pull out the Dialog into a new modal component (include stuff like the close button by default) that we can re-use across the whole project
- It would be good to setup linting and formatting as a Github action so it gets caught automatically
paulcretu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #361 and potentially #240